Skip to content
This repository was archived by the owner on Feb 12, 2024. It is now read-only.

feat: expose libp2p connection manager configuration options#1410

Merged
alanshaw merged 4 commits intomasterfrom
feat/expose-libp2p-connmgr-config
Jul 5, 2018
Merged

feat: expose libp2p connection manager configuration options#1410
alanshaw merged 4 commits intomasterfrom
feat/expose-libp2p-connmgr-config

Conversation

@alanshaw
Copy link
Member

@alanshaw alanshaw commented Jun 22, 2018

Exposes options for the connection manager (see https://github.com/libp2p/js-libp2p-connection-manager#create-a-connectionmanager) as an optional top level option called connectionManager.

@alanshaw alanshaw requested a review from daviddias June 22, 2018 09:56
@ghost ghost assigned alanshaw Jun 22, 2018
@ghost ghost added the status/in-progress In progress label Jun 22, 2018
self._options,
'EXPERIMENTAL.connectionManager',
get(config, 'EXPERIMENTAL.connectionManager')
)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No need to be experimental.

@daviddias daviddias changed the title [WIP] feat: expose libp2p connection manager configuration options feat: expose libp2p connection manager configuration options Jul 2, 2018
@alanshaw alanshaw mentioned this pull request Jul 3, 2018
23 tasks
@daviddias
Copy link
Member

libp2p/js-libp2p@b7f67f2 was released 4 days ago, anything else missing?

alanshaw added 2 commits July 3, 2018 14:46
License: MIT
Signed-off-by: Alan Shaw <alan@tableflip.io>
License: MIT
Signed-off-by: Alan Shaw <alan@tableflip.io>
@alanshaw alanshaw force-pushed the feat/expose-libp2p-connmgr-config branch from 2874fc8 to 0eaaf4f Compare July 3, 2018 14:51
alanshaw added 2 commits July 3, 2018 15:52
License: MIT
Signed-off-by: Alan Shaw <alan@tableflip.io>
License: MIT
Signed-off-by: Alan Shaw <alan@tableflip.io>
@alanshaw
Copy link
Member Author

alanshaw commented Jul 4, 2018

@diasdavid good to merge?

@alanshaw alanshaw merged commit 2615f76 into master Jul 5, 2018
@ghost ghost removed the status/in-progress In progress label Jul 5, 2018
@daviddias daviddias deleted the feat/expose-libp2p-connmgr-config branch July 5, 2018 06:00
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants